[core] Refactor ESLint config to disallow root level imports #13130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
added
core
|
Deploy preview: https://deploy-preview-13130--material-ui-x.netlify.app/ |
|
It impacts charts docs a lot, hence, I've asked for a review from @alexfauquette and @JCQuintas. 😉 |
alexfauquette
approved these changes
May 15, 2024
LukasTy
commented
May 15, 2024
Comment on lines
+5
to
+6
| import { PaperProps as MuiPaperProps } from '@mui/material/Paper'; | ||
| import { TransitionProps as MuiTransitionProps } from '@mui/material/transitions'; |
There was a problem hiding this comment.
These are almost a "bugfix". 🙈
Comment on lines
+215
to
+216
| ...buildPackageRestrictedImports('@mui/x-date-pickers', 'x-date-pickers', false), | ||
| ...buildPackageRestrictedImports('@mui/x-date-pickers-pro', 'x-date-pickers-pro', false), |
There was a problem hiding this comment.
Notice the package name and path fixes - technically ESLint was not working on Pickers packages
arthurbalduini
pushed a commit
to arthurbalduini/mui-x
that referenced
this pull request
May 23, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #13120.
@mui/x-codemodto ESLIntno-restricted-importsruleno-restricted-importsrule config for@mui/x-date-pickers*packages <-- did not work nowno-restricted-importsrule config to disallow root level package imports@mui/x-data-grid*and@mui/x-licensepackagesUseDateRangeFieldPropsfrom@mui/x-date-pickers-pro/modelsto avoid the need for public root importLocalizationProviderfrom@mui/x-date-pickers-pro/LocalizationProviderto avoid the need for public root import