[core] Remove raw-loader package
#13160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-13160--material-ui-x.netlify.app/ |
flaviendelangle
approved these changes
May 17, 2024
Janpot
approved these changes
May 17, 2024
|
I'm curious to know why we loose 1k lines and the core 33 😆 |
They already had |
|
Oh nice, I suspect we removed most of the dependency on raw-loader from mui/material-ui#26774. |
arthurbalduini
pushed a commit
to arthurbalduini/mui-x
that referenced
this pull request
May 23, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started looking at how to solve https://github.com/mui/mui-x/security/dependabot/119.
This lead me to the super old
raw-loaderpackage.Bumping to the latest version seemed to work.
Then I also tried removing the package—no issues after that as well. 🤔
We are running our
mdfiles through@mui/internal-markdown/loaderand that looks enough:mui-x/docs/next.config.mjs
Line 135 in fd544b7
MUI Core seems still have the
raw-loaderdependency, but it is not used anywhere as far as I can see...https://github.com/mui/material-ui/blob/cadb0b1b937b86b3be214ab65b1cc7067080f85a/package.json#L178