[pickers] Use useRtl instead of useTheme to access direction
#13363
Conversation
flaviendelangle
added
the
component: pickers
| @@ -144,12 +144,12 @@ export const getRangeFieldValueManager = <TDate extends PickerValidDate>({ | |||
| ...dateRangeSections.endDate, | |||
| ]); | |||
| }, | |||
| getV6InputValueFromSections: (sections, localizedDigits, isRTL) => { | |||
| getV6InputValueFromSections: (sections, localizedDigits, isRtl) => { | |||
There was a problem hiding this comment.
I unified to capitalization strategy of this variable with what the core is doing
|
Deploy preview: https://deploy-preview-13363--material-ui-x.netlify.app/ |
|
It's still in draft because I did not finished removing it 😆 |
| /** | ||
| * `true` if the application is in right-to-left direction. | ||
| */ | ||
| isRtl: boolean; |
There was a problem hiding this comment.
I'm adding it as a prop, because if we add it only to the ownerState, then it's a breaking change for people that are creating their own layout and re-using PickersLayoutRoot
To avoid this situation, we need to do the same thing I did in TreeItem2: add a getRootProp to usePickerLayout and add users to always spread it to PickersLayoutRoot (same for PickersLayoutContentWrapper), that way we can add props that directly be passed to those slots.
|
@LukasTy it's good for review |
Part of #12277
useRtlhas been added in@mui/system5.15.13 and we support 5.15.15 and above so we are good.I'm checking the approach with the core team before opening for review
Follow up
We need to replace all the imports and use
createUseThemePropsinstead ofuseThemePropsAnd do the same on the Tree View, which will be a lot easier