[charts] Introduce plugins system #13367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
the
component: charts
|
Deploy preview: https://deploy-preview-13367--material-ui-x.netlify.app/ |
JCQuintas
reviewed
Jun 5, 2024
| const plugin = defaultizedPlugins[i]; | ||
|
|
||
| // To remove those any we will need to solve this union discrimination issue: | ||
| // https://www.typescriptlang.org/play/?#code/FDAuE8AcFMAIDkCuBbARtATgYQPYDsAzASwHNYBeWAb2FlgGsi8ATALlgHI8V0MOBuWrBwwMAQ1A4M7ABQAPdtzSYAlBQB8sJb0EBfEBBiwAyqAxMSuQqQrUhjFuw4BnMxYFCRmCVNkLYruZ4JGrkmoEWeiAAxviuWqhWxCTsSMrY+Mm2VAxMbLAARNqYBQA0wqI+0rByGrAATLAAVDWw+rF48YFJpOymQZaZNpQ5DvkFEcFlFd6S1bVhsAAG9S0AJFRyukttMXGgsB3JzrYA2niJQyTl3VcAugZQcADylXPOALJikJAW2ULFDAAflSPEwPRIpw4XnEcw4d1KQkmJBBJjcwQhUJhVXhiN0gmAHXi2LmXx+FnYr1mUk+31+wWy+JABCksBkABtoAcjjYcARDldnGoaCA6AB6MWwADqUnoJxw9FgRH5AHc4L9ooroGJogALQ5iZxwPJEABuRGYiDE7PASJVRFAerZPJIADoxsKhHRooa4FwwXxWF66DNYVIyfTIS73Xk7rZoySpIIQyHUBhtfRkyGfUbOMiOEGU3RExgIxZTtGxnHKAm3kng8xoAQxIh2aBC0W0xms-pvftqLkWOUS2141chBLYABJDimuB4HBKxtiWBiVA4RAHXU4FWwSSwTkHAAqxlgiBYmFcYhYAusbrGq5vtepGFX6YPTHo0GYnjrpbp5ZVrYJZ6EAA |
There was a problem hiding this comment.
furthest I could get quickly is this, it solves the assignment type issue operatorMapping[kind] = operator, but doesn't solve accessing operatorMapping[kind]() typing issue :(
type OperatorsMapping<T extends NumberConfig | StringConfig= NumberConfig | StringConfig> = {
[k in T['kind']]?: T['operator']
}There was a problem hiding this comment.
I'm not sure it's feasible, but does not matter a lot. As long as the type constraint in the input/output of the hook are ok, it should not cause any issue
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
JCQuintas
reviewed
Jun 5, 2024
Comment on lines
154
to
182
| PropTypes.oneOfType([ | ||
| PropTypes.shape({ | ||
| colorProcessor: PropTypes.func.isRequired, | ||
| seriesFormatter: PropTypes.func.isRequired, | ||
| seriesType: PropTypes.oneOf(['bar']).isRequired, | ||
| xExtremumGetter: PropTypes.func, | ||
| yExtremumGetter: PropTypes.func, | ||
| }), | ||
| PropTypes.shape({ | ||
| colorProcessor: PropTypes.func.isRequired, | ||
| seriesFormatter: PropTypes.func.isRequired, | ||
| seriesType: PropTypes.oneOf(['line']).isRequired, | ||
| xExtremumGetter: PropTypes.func, | ||
| yExtremumGetter: PropTypes.func, | ||
| }), | ||
| PropTypes.shape({ | ||
| colorProcessor: PropTypes.func.isRequired, | ||
| seriesFormatter: PropTypes.func.isRequired, | ||
| seriesType: PropTypes.oneOf(['scatter']).isRequired, | ||
| xExtremumGetter: PropTypes.func, | ||
| yExtremumGetter: PropTypes.func, | ||
| }), | ||
| PropTypes.shape({ | ||
| colorProcessor: PropTypes.func.isRequired, | ||
| seriesFormatter: PropTypes.func.isRequired, | ||
| seriesType: PropTypes.oneOf(['pie']).isRequired, | ||
| xExtremumGetter: PropTypes.func, | ||
| yExtremumGetter: PropTypes.func, | ||
| }), |
There was a problem hiding this comment.
this proptype seem overly verbose 😅
There was a problem hiding this comment.
Yes, could be removed :)
I think I did it in the main PR, but forgot to extract it 👍
| line: lineSeriesFormatter, | ||
| pie: pieSeriesFormatter, | ||
| export type SeriesFormatterConfig<T extends ChartSeriesType = ChartSeriesType> = { | ||
| // TODO replace the function type by Formatter<K> |
There was a problem hiding this comment.
Not in this PR, because it impacts such a big part of the codebase that it would require a dedicated PR
| @@ -10,7 +10,7 @@ import { SeriesId } from './common'; | |||
| export interface ChartsSeriesConfig { | |||
| bar: { | |||
| /** | |||
| * Series type when passed to the formatter (some ids are defaultised to simplify the DX) | |||
| * Series type when passed to the formatter (some ids are defaultized to simplify the DX) | |||
There was a problem hiding this comment.
Suggested change
| * Series type when passed to the formatter (some ids are defaultized to simplify the DX) | |
| * Series type when passed to the formatter (some ids are given default values to simplify the DX) |
JCQuintas
approved these changes
Jun 6, 2024
This was referenced Jul 12, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #13366 extracted from #13209