Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TreeView] Add label editing feature #13388

Merged
merged 110 commits into from
Aug 13, 2024
Merged

[TreeView] Add label editing feature #13388

merged 110 commits into from
Aug 13, 2024

Conversation

noraleonte
Copy link
Contributor

@noraleonte noraleonte commented Jun 5, 2024 •
edited by flaviendelangle
Loading

Preview:

https://deploy-preview-13388--material-ui-x.netlify.app/x/react-tree-view/rich-tree-view/editing/

To do:

  • Finetune the behavior on double click
  • add callback method
  • finetune api for controlling the editing state (and limiting it to icon buttons as opposed to keyboard interactions)
  • create docs
  • styling of the editing state
  • tests

@noraleonte noraleonte added new feature New feature or request component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Jun 5, 2024
@noraleonte noraleonte self-assigned this Jun 5, 2024
@mui-bot
Copy link

mui-bot commented Jun 5, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-13388--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 1107002

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 10, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 17, 2024
flaviendelangle
flaviendelangle reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me we are almost good to go

I think we need to make the feature unstable like the drag & drop one, I would follow the same pattern and just add an experimentalFeature={{ labelEditing }} flag.

docs/data/tree-view/rich-tree-view/editing/CustomLabelInput.tsx Outdated Show resolved Hide resolved
docs/data/tree-view/rich-tree-view/editing/EditLeaves.js Outdated Show resolved Hide resolved
docs/data/tree-view/rich-tree-view/editing/Validation.tsx Outdated Show resolved Hide resolved
docs/data/tree-view/rich-tree-view/editing/Validation.tsx Show resolved Hide resolved
docs/data/tree-view/rich-tree-view/editing/Validation.tsx Outdated Show resolved Hide resolved
docs/data/tree-view/rich-tree-view/editing/editing.md Outdated Show resolved Hide resolved
packages/x-tree-view/src/TreeItem/TreeItem.tsx Outdated Show resolved Hide resolved
noraleonte and others added 6 commits August 6, 2024 13:56
LukasTy
LukasTy reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, awesome work! 🎉💯
Leaving a couple final comments regarding demos. 👍

docs/data/tree-view/rich-tree-view/editing/Validation.tsx Show resolved Hide resolved
docs/data/tree-view/rich-tree-view/editing/EditWithIcons.tsx Show resolved Hide resolved
LukasTy
LukasTy approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, congrats! 👍 💯 💙 🚀

flaviendelangle
flaviendelangle approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the terrific work on this feature! 👏

@noraleonte noraleonte merged commit 471b118 into mui:master Aug 13, 2024
18 checks passed
@noraleonte noraleonte deleted the label-editing branch August 13, 2024 12:08
@shagg0r shagg0r mentioned this pull request Sep 14, 2024
Open
@alhabib5565 alhabib5565 mentioned this pull request Sep 14, 2024
Open
@mbreadmachine mbreadmachine mentioned this pull request Sep 14, 2024
Closed
@alhabib5565 alhabib5565 mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 19, 2024
Closed
Closed
This was referenced Sep 20, 2024
Open
Open
Open
Open
Open
@mbreadmachine mbreadmachine mentioned this pull request Sep 25, 2024
Closed
@noraleonte noraleonte mentioned this pull request Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette left review comments

@LukasTy LukasTy LukasTy approved these changes

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@joserodolfofreitas joserodolfofreitas Awaiting requested review from joserodolfofreitas

@KenanYusuf KenanYusuf Awaiting requested review from KenanYusuf

Assignees

@noraleonte noraleonte

Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@noraleonte @mui-bot @flaviendelangle @KenanYusuf @LukasTy @alexfauquette