Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TreeView] Prepare support for PigmentCSS #13412

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Jun 7, 2024

Closes #12278

@flaviendelangle flaviendelangle added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label Jun 7, 2024
@flaviendelangle flaviendelangle self-assigned this Jun 7, 2024
@mui-bot
Copy link

mui-bot commented Jun 7, 2024

Deploy preview: https://deploy-preview-13412--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against b083d9a

@flaviendelangle flaviendelangle changed the title [TreeView] Prepare for PigmentCSS support [TreeView] Prepare support for PigmentCSS Jun 7, 2024
@flaviendelangle flaviendelangle marked this pull request as ready for review June 7, 2024 06:56
Copy link

@brijeshb42 brijeshb42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to the changes. cc: @siriwatknp since you've already done this for material-ui.

@@ -10,6 +9,7 @@ import {
buildWarning,
extractPluginParamsFromProps,
} from '@mui/x-tree-view/internals';
import { styled, createUseThemeProps } from '../internals/zero-styled';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This should work as long as it has zero-styled.

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looks good to me. Let me know when it is released, I'd love to try.

@flaviendelangle
Copy link
Member Author

✅ Looks good to me. Let me know when it is released, I'd love to try.

I will be released this Thursday / Friday 👍

@flaviendelangle flaviendelangle merged commit 40e631d into mui:master Jun 10, 2024
17 checks passed
@flaviendelangle flaviendelangle deleted the tree-view-pigmentcss branch June 10, 2024 08:51
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tree view] Add support for zero runtime CSS (pigmentcss)
4 participants