-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update a11y pages description #13417
Merged
danilo-leal
merged 2 commits into
mui:master
from
danilo-leal:update-a11y-pages-description
Jun 10, 2024
Merged
[docs] Update a11y pages description #13417
danilo-leal
merged 2 commits into
mui:master
from
danilo-leal:update-a11y-pages-description
Jun 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noraleonte
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this 🎉
samuelsycamore
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one small grammar fix that Nora already pointed out, otherwise I'm tentatively approving 👍
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com> Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
This was referenced Jul 12, 2024
This was referenced Jul 20, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com>
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were talking about documenting accessibility testing guidelines in one of the Core meetings and eventually touched on how the Tree View component implemented keyboard navigation. Then, on each accessibility page, we realized we were saying "complete accessibility support" which is arguably one thing we can't ever say—we don't know if we're supporting every single accessibility-related feature or if we're being fully accessible, particularly given there's very little focus on, in any of these pages, screen readers; they're mostly focused on keyboard navigation.
So, this PR changes the descriptions of the accessibility-focused pages a bit to reflect that train of thought.