Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update a11y pages description #13417

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

danilo-leal
Copy link
Contributor

We were talking about documenting accessibility testing guidelines in one of the Core meetings and eventually touched on how the Tree View component implemented keyboard navigation. Then, on each accessibility page, we realized we were saying "complete accessibility support" which is arguably one thing we can't ever say—we don't know if we're supporting every single accessibility-related feature or if we're being fully accessible, particularly given there's very little focus on, in any of these pages, screen readers; they're mostly focused on keyboard navigation.

So, this PR changes the descriptions of the accessibility-focused pages a bit to reflect that train of thought.

@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label Jun 7, 2024
@danilo-leal danilo-leal self-assigned this Jun 7, 2024
Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 🎉

docs/data/date-pickers/accessibility/accessibility.md Outdated Show resolved Hide resolved
Copy link
Contributor

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small grammar fix that Nora already pointed out, otherwise I'm tentatively approving 👍

Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com>
Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
@danilo-leal danilo-leal merged commit c138826 into mui:master Jun 10, 2024
17 checks passed
@danilo-leal danilo-leal deleted the update-a11y-pages-description branch June 10, 2024 14:06
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com>
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants