Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Adjust CI setup #13448

Merged
merged 3 commits into from
Jun 12, 2024
Merged

[infra] Adjust CI setup #13448

merged 3 commits into from
Jun 12, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Jun 11, 2024

  • Use a regular docker container for the danger step as the playwright does not seem to need it... 🤷 🙈
  • Use the same pnpm version as in package.json
    • using latest-8 is no longer correct as we already use v9
    • using latest-9 is potentially incorrect depending on which version is specified in package.json.
      Do you know if omitting the @ portion would end up using the package.json specifier? @Janpot @michaldudak I see that both base-ui and toolpad do not call corepack prepare. Have you seen any problems with it? Or maybe we could also remove it? 🤔
      Removed the corepack prepare as agreed here: [infra] Adjust CI setup #13448 (review)

@LukasTy LukasTy added core Infrastructure work going on behind the scenes scope: infra Org infrastructure work going on behind the scenes labels Jun 11, 2024
@LukasTy LukasTy self-assigned this Jun 11, 2024
@mui-bot
Copy link

mui-bot commented Jun 11, 2024

Deploy preview: https://deploy-preview-13448--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 267791c

@LukasTy LukasTy requested review from a team June 11, 2024 15:05
.circleci/config.yml Outdated Show resolved Hide resolved
Co-authored-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
Signed-off-by: Lukas <llukas.tyla@gmail.com>
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@LukasTy LukasTy merged commit 9da1990 into mui:master Jun 12, 2024
17 checks passed
@LukasTy LukasTy deleted the ci-config-adjustments branch June 12, 2024 06:51
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
Signed-off-by: Lukas <llukas.tyla@gmail.com>
Co-authored-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Signed-off-by: Lukas <llukas.tyla@gmail.com>
Co-authored-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes scope: infra Org infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants