-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Fix AdapterDateFnsV3
generated method types
#13464
[pickers] Fix AdapterDateFnsV3
generated method types
#13464
Conversation
Deploy preview: https://deploy-preview-13464--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! 🙏
I think that adding explicit types to the V2
adapters wouldn't hurt as well as it would allow us to avoid this problem if we keep both adapters, but just swap the defaults (use v3 in the repo as the default).
It's not a deal-breaker, but depending on who would take on that work and reviewing it, this additional work could help avoiding a very similar problem with V2 adapter in that case.
WDYT? 🤔
AdapterDateFnsV3
generated method types
@LukasTy makes sense. I’m away from laptop till next week, will come back to it Monday and supply for date-fns v2 |
Ok, thanks for the update, let's wait for next week. 👌 |
b9a0129
to
e375906
Compare
@LukasTy all done. Have a look please once you have time 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for taking care of it! 🙏
Great job. 👏 💯
Fixes #13226 as suggested in the comments.
Applied to both
AdapterDateFnsJalaliV3
&AdapterDateFnsV3
who rely on date-fns-v3UPD: Applied to Adapters based on date-fns-v2 as well so the don't lose types when dependency is switched to date-fns-v3