[DataGrid] Fix incorrect panels position when using a toolbar #13474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannager
added
the
component: data grid
oukunan
force-pushed
the
fix-incorrectly-poppers-positioned-toolbar
branch
from
d374c4f
to
a60177a
Compare
| role="presentation" | ||
| /> | ||
| > | ||
| <GridPanelAnchor role="presentation" data-id="gridPanelAnchor" /> |
There was a problem hiding this comment.
Thanks @oukunan, nice catch!
Unfortunately, putting GridPanelAnchor here causes an issue when scrolling horizontally:
https://codesandbox.io/p/sandbox/silly-firefly-hmtdfn
Screen.Recording.2024-07-10.at.21.33.45.mov
I'll update the PR with a fix.
|
Deploy preview: https://deploy-preview-13474--material-ui-x.netlify.app/ |
cherniavskii
changed the title
cherniavskii
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #13442
Preview: https://deploy-preview-13474--material-ui-x.netlify.app/x/react-data-grid/#premium-plan