[docs] Document the PickerValidDate type override
#13476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
docs
flaviendelangle
commented
Jun 14, 2024
docs/data/migration/migration-pickers-v6/migration-pickers-v6.md
Outdated
Show resolved
Hide resolved
flaviendelangle
changed the title
PickerValidDate type override
LukasTy
approved these changes
Jun 14, 2024
docs/data/migration/migration-pickers-v6/migration-pickers-v6.md
Outdated
Show resolved
Hide resolved
docs/data/migration/migration-pickers-v6/migration-pickers-v6.md
Outdated
Show resolved
Hide resolved
docs/data/migration/migration-pickers-v6/migration-pickers-v6.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Lukas <llukas.tyla@gmail.com> Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com> Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
LukasTy
approved these changes
Jun 14, 2024
| All the date-related props are now strictly typed to only accept the date format supported by your adapter | ||
| (`Date` object for `date-fns`, `daysjs.Dayjs` object for `days-js`, etc.). | ||
|
|
||
| You can learn more about this change in the [dedicated doc section](/x/react-date-pickers/base-concepts/#typing-of-the-date). |
There was a problem hiding this comment.
You can also consider using the format suggested by Sam on how to name the links to other doc sections.
Suggested change
| You can learn more about this change in the [dedicated doc section](/x/react-date-pickers/base-concepts/#typing-of-the-date). | |
| :::info | |
| See [Base concepts—Typing of the date](/x/react-date-pickers/base-concepts/#typing-of-the-date) for more details. | |
| ::: |
There was a problem hiding this comment.
Would you apply the same rational to the other "You can learn more" of the page?
There was a problem hiding this comment.
It's just a suggestion, but especially in this section, I think that it would improve the visibility and importance of the link.
As for the other sections—it's up to you. Technically it's out of the scope of this issue, but I don't think it would hurt. 👌
There was a problem hiding this comment.
It's out of the scope but it's a super simple change that is not worth a dedicated review IMHO, I'll do the switch 👌
There was a problem hiding this comment.
I will do a follow up for the rest of the doc if I find some time
This was referenced Jul 13, 2024
This was referenced Jul 20, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com> Co-authored-by: Lukas <llukas.tyla@gmail.com>
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com> Co-authored-by: Lukas <llukas.tyla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12640