-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Add context to onAccept
callback
#13511
Conversation
Deploy preview: https://deploy-preview-13511--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition! 🙏
Thank you for taking care of it. 👍
Do you have any idea of what we can showcase with it?
Currently it seems that this addition will allow preventing srange behaviors if users are relying on onAccept
for certain triggers. 🤔
But if you have ideas for documentation—"I'm all ears". 👍
I think the Maybe we could rename the sections in Pickers lifecycle to be |
I do agree, we could improve on that. 👍
Given your suggestion, it seems that this idea is out of the scope of this issue/PR. 🤔 |
Yes, I can do it in a follow up |
Closes #11978
Do you think we should add a demo? And if so, where?