-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts] Export Pro
versions of regular charts
#13547
Conversation
Deploy preview: https://deploy-preview-13547--material-ui-x.netlify.app/ |
Since it's not impacted by the zooming, I propose do don't create it for now |
What do you think about an internal Like that we would be sure that props propagation in the community and pro package keep in sync. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
🤔 can try it out |
The scatter chart experiment seems promising 🚀 |
@alexfauquette should be ready for review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the CI (some empty lines removed by pnpm proptypes)
I also removed the proptypes of the pro components, because they are not generated for now.
THis will be availabel after uncommenting this : https://github.com/mui/mui-x/blob/master/docs/scripts/createXTypeScriptProjects.ts/#L320-L337
Co-authored-by: alexandre <alex.fauquette@gmail.com>
Co-authored-by: alexandre <alex.fauquette@gmail.com>
BarChartPro
LineChartPro
ScatterChartPro
???
PieChartPro
?related #13405