Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove "-" in heat-map and tree-map urls #13569

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

alexfauquette
Copy link
Member

Since we plan to call those components Heatmap and Treemap having a "-" in the url makes no sense. So I propose to fix h=this before releasing one of those components

@alexfauquette alexfauquette added docs Improvements or additions to the documentation component: charts This is the name of the generic UI component, not the React module! labels Jun 20, 2024
@mui-bot
Copy link

mui-bot commented Jun 20, 2024

@alexfauquette alexfauquette merged commit 2f7ed23 into mui:master Jun 20, 2024
15 of 17 checks passed
@alexfauquette alexfauquette deleted the rename-heatmap branch June 20, 2024 15:13
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 20, 2024

Maybe we should update:

const usedLinks = { ...usedLinksCore, ...usedLinksX };

to be:

 const usedLinks = usedLinksX; 

I'm not sure that checking links across Base UI, Material UI, and Joy UI repositories in the future will scale well (e.g. this PR whose build is failing because we need mui/material-ui#42697). But it's indeed nice that this works today.

@alexfauquette
Copy link
Member Author

alexfauquette commented Jun 21, 2024

The impact on other PR is more my fault than the script.

You can bypass the test by running it locally and saving the updated file.

About this specific PR: I merged a PR with the test broken because I remembered I can bypass it, but obviously it was not the correct way to do it

About linking to base, joy, material, and the blog. The main reason was the rewording effort of Sam. Because titles impact the anchor link, and so our link anchor to the core got broken frequently

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 21, 2024

You can bypass the test by running it locally and saving the updated file.

Fair enough, this works as well.

Because titles impact the anchor link, and so our link anchor to the core got broken frequently

I see, even ahrefs doesn't report them. Don't hesitate to upvote https://ahrefs.canny.io/site-audit/p/find-broken-html-anchor-link 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants