Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add missing default loading prop value #13604

Merged
merged 3 commits into from
Jul 9, 2024
Merged

[docs] Add missing default loading prop value #13604

merged 3 commits into from
Jul 9, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jun 23, 2024 •
edited
Loading

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! labels Jun 23, 2024
@mui-bot
Copy link

mui-bot commented Jun 23, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-13604--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 23b34b6

@MBilalShafi MBilalShafi changed the title [data grid][docs] Add missing default loading prop value [docs] Add missing default loading prop value Jul 9, 2024
@MBilalShafi MBilalShafi enabled auto-merge (squash) July 9, 2024 02:38
@MBilalShafi MBilalShafi merged commit 22f8f84 into mui:master Jul 9, 2024
15 checks passed
@oliviertassinari oliviertassinari deleted the add-missing-default branch July 9, 2024 20:52
@oliviertassinari
Copy link
Member Author

@MBilalShafi Thanks for completing the PR.

DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@oliviertassinari @MBilalShafi @DungTiger
[docs] Add missing default loading prop value (mui#13604)
354ca70 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
@oliviertassinari oliviertassinari mentioned this pull request Jul 29, 2024
Closed
@arnfinn arnfinn mentioned this pull request Aug 8, 2024
Closed
@alhabib5565 alhabib5565 mentioned this pull request Aug 19, 2024
Open
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@oliviertassinari @MBilalShafi @thomasmoon
[docs] Add missing default loading prop value (mui#13604)
4f09889 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @mui-bot @MBilalShafi