[TreeView] Support experimental features from plugin's dependencies #13632
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: tree view
flaviendelangle
commented
Jun 26, 2024
| @@ -38,4 +38,5 @@ export type TreeViewPublicAPI< | |||
|
|
|||
| export type TreeViewExperimentalFeatures< | |||
| TSignatures extends readonly TreeViewAnyPluginSignature[], | |||
| > = { [key in MergeSignaturesProperty<TSignatures, 'experimentalFeatures'>]?: boolean }; | |||
| TOptionalSignatures extends readonly TreeViewAnyPluginSignature[] = [], | |||
| > = MergeSignaturesProperty<[...TSignatures, ...TOptionalSignatures], 'experimentalFeatures'>; | |||
There was a problem hiding this comment.
I also added support for the optional plugins even if we never use it for now, just to be consistent with the instance and params
|
Deploy preview: https://deploy-preview-13632--material-ui-x.netlify.app/ |
alexfauquette
approved these changes
Jun 26, 2024
This was referenced Jul 20, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
This was referenced Jul 27, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #13520, I noticed that if a plugin had an experimental feature and one of its dependencies also had an experimental feature, then the typing broke.
The reason is that calling
MergeSignaturesPropertyon a union did not work (we ended up with'virtualization' & 'indentationPerLevel'instead of'virtualization' | 'indentationPerLevel'.I changed the logic to instead transform the experimental features into an object inside
TreeViewPluginSignatureto keep all the merging strategies consistent.