[fields] Fix section clearing behavior on Android #13652
Merged
+18
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
added
bug 🐛
|
Deploy preview: https://deploy-preview-13652--material-ui-x.netlify.app/ |
flaviendelangle
approved these changes
Jun 28, 2024
LukasTy
commented
Jun 28, 2024
| (inputRef.current.selectionStart !== selectionStart || | ||
| inputRef.current.selectionEnd !== selectionEnd) | ||
| ) { | ||
| interactions.syncSelectionToDOM(); |
There was a problem hiding this comment.
I'm afraid of a possible endless recursion here. 🤔
WDYT, do we need an additional safeguard against it here?
There was a problem hiding this comment.
Do you have a clearer idea of a scenario when this recursion might happen?
Tbh I don't really know how to add safeguards here 😬
It's better on |
Merged
This was referenced Jul 20, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
This was referenced Jul 27, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13620
Related to #10399.
The present behavior and test for section clearing on Android seemed incorrect.
It doesn't work like that on Desktop.
The change aligns the section clearing behavior between Desktop and Android.
There is still an issue on Chrome on Android with syncing the focus on a section, which has a different length placeholder than the value (i.e. full length month).screen-20240628-160431.2.mp4
Maybe because it requires an extra repaint/resize cycle. 🤷If you have ideas on how to solve it—I'm all ears.
P.S. Wrapping the
syncSelectionToDOMcall in asetTimeoutfixes the issue, but introduces a delay and causes the caret to be momentarily visible.P.P.S. The situation with the MS Swiftkey keyboard is even worse... All the section selections are no syncked after section removal. 🙈
This fix seems to avoid the problem and works stable: 73ed8e9 (albeit with a slight chance of endless recursion in an unforeseen case).
In any case, I'd be happy to ship this fix as is, because the current state of Chrome on Android with Gboard is pretty bad-unusable when deleting. 🙈