-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Add demo to the "Custom columns" page that does not use generator #13695
Conversation
Deploy preview: https://deploy-preview-13695--material-ui-x.netlify.app/ Updated pages: |
4f79858
to
274b9cc
Compare
There is an issue with the toolbar that I will have to fix in https://github.com/mui/material-ui first Once I have the other PR I will link it here Docs infra PR |
2505bcf
to
51d1415
Compare
51d1415
to
f7114db
Compare
Before the PR is merged, mui/material-ui#42733 should be resolved |
We need to link to this demo in https://mui.com/x/react-data-grid/faq/#what-is-the-purpose-of-usedemodata-hook-used-in-the-documentation-examples (adding a callout), so that users that are looking for This will close #13110, as duplicating |
@arminmeh please review my changes and let me know what you think |
Thanks for taking over @cherniavskii the changes are fine, but I still see issues with the CodeSandbox/StackBlitz demos on the preview page I see that in mui/material-ui#41754 that the issue for CodeSandbox/StackBlitz is closed, but the checkbox is not checked |
Ah no, that checkbox is supposed to be checked since the issue was supposed to be resolved with that PR. While the original issue was fixed, I can look into what's causing the issue in this particular demo |
@bharatkashyap @arminmeh I've opened mui/material-ui#43713 with a fix |
@arminmeh The demo now works in Stackblitz and Codesandbox, thanks for spotting it! |
@cherniavskii thanks for the sandbox fixes and for the updates that made it finally merged 🥳 |
…nerator (mui#13695) Co-authored-by: Andrew Cherniavskyi <andrew@mui.com>
Closes #13110
Closes #9270
Only last point from the proposal was actually missing (example without generator)
I have added a demo that collects most customized cell renderers that we have in our docs.
@mui/x-data-grid-generator
is still used toget the actuall renderers and togenerate random dataPreview: https://deploy-preview-13695--material-ui-x.netlify.app/x/react-data-grid/custom-columns/#full-example
Update
Renderers are outside of the main folder of the component's docs to skip the regression tests
This produces the same problem with the long names as discussed in mui/material-ui#42913 (comment)
So, I will add a feature to "Allow using custom labels (default to filename) for imported files, instead of entire relative path"
from mui/material-ui#41754
TODO