-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Sort Pickers & Charts API slots alphabetically #13843
Conversation
Deploy preview: https://deploy-preview-13843--material-ui-x.netlify.app/ |
I think this would be useful for charts as well 👍 |
I just wanted to let you know, that flakiness has been observed only for Pickers previously and now again. 🤔 |
We see it on charts too, the flakiness |
Oh, sorry, I didn't notice it then. 🙈 |
@LukasTy it usually happens in the pull request themselves when we change import orders. Sometimes it creates a chain effect that changes a lot of files :( |
Gotcha. I've added Charts to the sorted list. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ok for charts 👍
Thanks for taking care of it :)
Once again
api:docs
generation results have become flaky and sometimes keep failing in CI: https://app.circleci.com/pipelines/github/mui/mui-x/61920/workflows/b0db904d-129e-4379-9d5d-e7f23d837aea/jobs/353446.Sorting them alphabetically would ensure this wouldn't happen. 🤔
Also added the same sorting for the Charts package based on: #13843 (comment)