Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TreeView] Extract some logic outside of the useTreeView hook #13845

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Jul 15, 2024

I tried to improve the readability of the useTreeVIew hook which is quite complex

@flaviendelangle flaviendelangle added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label Jul 15, 2024
@flaviendelangle flaviendelangle self-assigned this Jul 15, 2024
@mui-bot
Copy link

mui-bot commented Jul 15, 2024

Deploy preview: https://deploy-preview-13845--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 0f3e703

@flaviendelangle flaviendelangle marked this pull request as draft July 15, 2024 12:23
@flaviendelangle flaviendelangle marked this pull request as ready for review July 16, 2024 10:52
Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! 🎉

@flaviendelangle flaviendelangle merged commit 569413a into mui:master Jul 16, 2024
17 checks passed
@flaviendelangle flaviendelangle deleted the clean-useTreeView branch July 16, 2024 12:27
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants