Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Remove dead code in internal GridPreferencesPanel #13934

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

k-rajat19
Copy link
Contributor

@k-rajat19 k-rajat19 commented Jul 21, 2024

props and ref are not used anywhere, so its safe to remove them

A leftover from #11228.

@oliviertassinari oliviertassinari changed the title [data-grid] remove redundant code [data grid] Remove dead code in internal GridPreferencesPanel Jul 21, 2024
@oliviertassinari oliviertassinari added performance component: data grid This is the name of the generic UI component, not the React module! labels Jul 21, 2024
@k-rajat19
Copy link
Contributor Author

@romgrk would you like to review these changes 🙂

@romgrk romgrk enabled auto-merge (squash) July 23, 2024 11:36
@mui-bot
Copy link

mui-bot commented Jul 23, 2024

Deploy preview: https://deploy-preview-13934--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 97ffffb

@romgrk romgrk merged commit 6d18f15 into mui:master Jul 23, 2024
15 checks passed
@k-rajat19 k-rajat19 deleted the grid-panel branch July 23, 2024 13:26
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants