-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Use Netflix financial results to document bar charts #13991
Conversation
Deploy preview: https://deploy-preview-13991--material-ui-x.netlify.app/ |
458cf99
to
a272ad4
Compare
{ dataKey: 'treas', stack: 'equity' }, | ||
])} | ||
xAxis={[{ scaleType: 'band', dataKey: 'year' }]} | ||
slotProps={{ legend: { hidden: true } }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to remove it? Seems like it could be helpful for the user to understand how the charts work 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment, otherwise looks good
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
CodSpeed Performance ReportMerging #13991 will not alter performanceComparing Summary
|
I took Netflix financial results from Yahoo Finance and used it to illustrate bar chart staking. The underlying idea is that financial data are composed of sub-data. For example, assets are divided into short-term and long-term ones, which is well suited for staked bars.
But I'm uncertain this helps to make the docs more appealing and do not disturb the learning aspect
https://deploy-preview-13991--material-ui-x.netlify.app/x/react-charts/bars/#bar-size
https://deploy-preview-13991--material-ui-x.netlify.app/x/react-charts/bars/#stacking