-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts] Rename CartesianContextProvider
to CartesianProvider
#14102
Conversation
Deploy preview: https://deploy-preview-14102--material-ui-x.netlify.app/ |
CodSpeed Performance ReportMerging #14102 will not alter performanceComparing Summary
|
@alexfauquette this should be ready to review and decrease the amount of lines on #14121 😆 |
<ZoomProvider {...zoomProviderProps}> | ||
<SeriesProvider {...seriesProviderProps}> | ||
<CartesianProviderPro {...cartesianProviderProps}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the reordeing has a reason in the PR for zoom filterMode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, though I think in the end I didn't use it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this can be reverted then to avoid introducing modification. But that recommendation seems more like psychologic safety than true engineering 😇
<ZoomProvider {...zoomProviderProps}> | ||
<SeriesProvider {...seriesProviderProps}> | ||
<CartesianProviderPro {...cartesianProviderProps}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this can be reverted then to avoid introducing modification. But that recommendation seems more like psychologic safety than true engineering 😇
One more renaming 🙃