[core] Bump monorepo #14141

Janpot · 2024-08-08T14:30:57Z

Just realized I made a few breaking changes in the eslint setup.

@LukasTy Just have two errors on nested imports from the pickers package. How would you prefer to deal with those? just Ignore? Disable in config? Or move the export up one level?

mui-bot · 2024-08-08T14:34:55Z

Deploy preview: https://deploy-preview-14141--material-ui-x.netlify.app/

Updated pages:

docs/data/date-pickers/lifecycle/lifecycle.md

Generated by 🚫 dangerJS against 0996edf

docs/src/modules/components/overview/mainDemo/DigitalClock.tsx

docs/src/modules/components/PickersPlayground.tsx

alexfauquette · 2024-08-12T09:59:45Z

I updated the PR to

include the fix to have working codesandboxe demonstrations with multiple files [docs-infra] Fix broken sandboxes with relative module imports material-ui#42767
I fixed the link check that is only on mui-x. Others should be done in [docs] Fix broken links material-ui#43144

LukasTy

I've removed the introduction of type exporting by removing the internal type usage in documentation page component.

docs/data/date-pickers/lifecycle/lifecycle.md

docs/src/modules/components/overview/mainDemo/DigitalClock.tsx

LukasTy · 2024-08-12T15:02:36Z

@Janpot Is there anything else we are waiting for this PR to be ready?

Janpot · 2024-08-12T15:51:18Z

Is there anything else we are waiting for this PR to be ready?

I haven't addressed this yet. But I can also look into it separately, doesn't necessarily have to be a blocker.

LukasTy · 2024-08-12T15:54:31Z

I haven't addressed this yet. But I can also look into it separately, doesn't necessarily have to be a blocker.

It could be due to a misconfigured eslint config on the mui-x side. 🙈
I would vote for ignoring this question, at least for the time being. 👍

Janpot · 2024-08-12T16:04:15Z

It could be due to a misconfigured eslint config on the mui-x side.

It's likely that the X version of this rule is overwriting a default somewhere. It's quite complicated to extend this rule. Core wasn't even doing it correctly within its repo. It's not a huge problem, I saw that X has made a very detailed setup, I'd like to bring some of this infra to core.

Janpot · 2024-08-13T14:24:40Z

@LukasTy
Ok, I touched up the no-restricted-import rule and this brought up a few issues. Fixed most of them. I added exceptions for:

@mui/x-date-pickers/internals/demo
@mui/x-tree-view/hooks/useTreeViewApiRef
@mui/material/ButtonBase/TouchRipple: This will definitely need to be fixed, it'll break once we move to package exports

In general I'd recommend against deeper imports, we're having this convention, It'll be easier to manage our linting rules and build tools if we adhere to it and not have to declare exceptions every time. I'd keep it for when there's a real good reason to do so.

Found an issue where @mui/monorepo/docs/... was imported instead of the alias docs/... and found that the alias was incorrectly defined. that's why // @ts-ignore was used everywhere this was imported. This is fixed now as well

LukasTy · 2024-08-13T14:31:43Z

Nice, thanks @Janpot, looks great! 👏 💙

alexfauquette · 2024-08-13T15:01:54Z

The TS error import ... from 'packages/api-docs-builder'; does not exist

Has been fixed in mui/material-ui#43199 just merged so bumping could solve some errors.

But most of them are from missing type for react-docgen. Those types are defined here: https://github.com/mui/material-ui/tree/next/packages/react-docgen-types

But I'm not sure if it should be fixed on the core repository, or if tsconfig should point to the monorepo on X side

LukasTy · 2024-08-13T15:16:04Z

But I'm not sure if it should be fixed on the core repository, or if tsconfig should point to the monorepo on X side

Without a too-deep investigation, I think we should add this path to the types in the tsconfig on the X side.

alexfauquette · 2024-08-13T16:07:37Z

I tried "@types/react-docgen": ["./node_modules/@mui/monorepo/packages/react-docgen-types"], in multiple places without success

Janpot · 2024-08-13T19:51:36Z

I don't think tsconfig paths apply to anything else than project files, so it's in code that we will need to reference this @types/react-docgen that we supplied in the paths. Here I'm doing it in a docs-env.d.ts that I introduce to the compilation in the tsconfig include.
Also pulled in some fixes from PR mui/material-ui#43285. To be merged first.

Janpot · 2024-08-14T07:09:48Z

docs/data/charts/pie-demo/OnSeriesItemClick.js

@@ -1,7 +1,8 @@
 import * as React from 'react';
 import { PieChart } from '@mui/x-charts/PieChart';



Can't remove this newline for some reason. But didn't take the time to look into it.

This behavior is known and we tend to ignore it. 🙈
P.S. I take it that adding type after import doesn't change anything? 🤔

It signals compilers that this import is not usable as a javascript value. Can be important depending on the context this is compiled in.

Janpot · 2024-08-14T07:31:03Z

Should be ready to review. Have a small comment that we could still resolve. I'm a bit allergic to as any 😄

LukasTy

LGTM!
Thank you for the effort once again. 🙏

alexfauquette

Thanks for all the fixes.

[core] Bump monorepo

80b202e

Janpot added the dependencies Update of dependencies label Aug 8, 2024

LukasTy reviewed Aug 8, 2024

View reviewed changes

docs/src/modules/components/overview/mainDemo/DigitalClock.tsx Outdated Show resolved Hide resolved

docs/src/modules/components/PickersPlayground.tsx Outdated Show resolved Hide resolved

Janpot and others added 3 commits August 8, 2024 16:54

fix one

3da7a84

fixes

117d6cf

Add codesandbox fix and fix link check

f985a6a

LukasTy added 2 commits August 12, 2024 16:44

Avoid the need for internal type usage in docs

18e1803

docs:api

4235c20

LukasTy approved these changes Aug 12, 2024

View reviewed changes

docs/data/date-pickers/lifecycle/lifecycle.md Show resolved Hide resolved

docs/src/modules/components/overview/mainDemo/DigitalClock.tsx Outdated Show resolved Hide resolved

Janpot added 4 commits August 13, 2024 15:10

update rule

c884871

Fix rule

854ed25

fix ts ignores

385dbda

Updates

1a019ea

Update OnSeriesItemClick.js

aa44a43

Janpot added 2 commits August 13, 2024 21:35

working on types

ef3d7fd

fix

75e880d

Janpot mentioned this pull request Aug 13, 2024

[docs-infra] Fix some TS issues for X docs mui/material-ui#43285

Merged

bring back monorepo

0b735eb

Janpot commented Aug 14, 2024

View reviewed changes

Janpot marked this pull request as ready for review August 14, 2024 07:29

LukasTy approved these changes Aug 14, 2024

View reviewed changes

alexfauquette approved these changes Aug 14, 2024

View reviewed changes

Avoid any cast

0996edf

Janpot merged commit a091eeb into mui:master Aug 14, 2024
18 checks passed

Janpot deleted the monorepo branch August 14, 2024 08:17

shagg0r mentioned this pull request Sep 14, 2024

[Snyk] Upgrade: , , , , , , , , shagg0r/test#4

Open

alhabib5565 mentioned this pull request Sep 14, 2024

[Snyk] Upgrade: , , , , axios, dayjs, framer-motion, next, react-hook-form, swiper alhabib5565/quick-shop-client#15

Open

mbreadmachine mentioned this pull request Sep 14, 2024

[Snyk] Upgrade: , , , mbreadmachine/arany-d-osztaly-weboldal#33

Open

alhabib5565 mentioned this pull request Sep 18, 2024

[Snyk] Upgrade: , , , , axios, dayjs, framer-motion, next, react-hook-form, swiper alhabib5565/quick-shop-client#16

Open

mbreadmachine mentioned this pull request Sep 19, 2024

[Snyk] Upgrade: , , , mbreadmachine/arany-d-osztaly-weboldal#34

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[core] Bump monorepo #14141

[core] Bump monorepo #14141

Janpot commented Aug 8, 2024 •

edited by LukasTy

Loading

mui-bot commented Aug 8, 2024 •

edited

Loading

alexfauquette commented Aug 12, 2024 •

edited

Loading

LukasTy left a comment

LukasTy commented Aug 12, 2024

Janpot commented Aug 12, 2024 •

edited by LukasTy

Loading

LukasTy commented Aug 12, 2024

Janpot commented Aug 12, 2024

Janpot commented Aug 13, 2024 •

edited

Loading

LukasTy commented Aug 13, 2024

alexfauquette commented Aug 13, 2024

LukasTy commented Aug 13, 2024

alexfauquette commented Aug 13, 2024

Janpot commented Aug 13, 2024 •

edited

Loading

Janpot Aug 14, 2024

LukasTy Aug 14, 2024

Janpot Aug 14, 2024 •

edited

Loading

Janpot commented Aug 14, 2024

LukasTy left a comment

alexfauquette left a comment

		@@ -1,7 +1,8 @@
		import * as React from 'react';
		import { PieChart } from '@mui/x-charts/PieChart';

[core] Bump monorepo #14141

[core] Bump monorepo #14141

Conversation

Janpot commented Aug 8, 2024 • edited by LukasTy Loading

mui-bot commented Aug 8, 2024 • edited Loading

alexfauquette commented Aug 12, 2024 • edited Loading

LukasTy left a comment

Choose a reason for hiding this comment

LukasTy commented Aug 12, 2024

Janpot commented Aug 12, 2024 • edited by LukasTy Loading

LukasTy commented Aug 12, 2024

Janpot commented Aug 12, 2024

Janpot commented Aug 13, 2024 • edited Loading

LukasTy commented Aug 13, 2024

alexfauquette commented Aug 13, 2024

LukasTy commented Aug 13, 2024

alexfauquette commented Aug 13, 2024

Janpot commented Aug 13, 2024 • edited Loading

Janpot Aug 14, 2024

Choose a reason for hiding this comment

LukasTy Aug 14, 2024

Choose a reason for hiding this comment

Janpot Aug 14, 2024 • edited Loading

Choose a reason for hiding this comment

Janpot commented Aug 14, 2024

LukasTy left a comment

Choose a reason for hiding this comment

alexfauquette left a comment

Choose a reason for hiding this comment

Janpot commented Aug 8, 2024 •

edited by LukasTy

Loading

mui-bot commented Aug 8, 2024 •

edited

Loading

alexfauquette commented Aug 12, 2024 •

edited

Loading

Janpot commented Aug 12, 2024 •

edited by LukasTy

Loading

Janpot commented Aug 13, 2024 •

edited

Loading

Janpot commented Aug 13, 2024 •

edited

Loading

Janpot Aug 14, 2024 •

edited

Loading