[data-grid]: use event.type for detecting IME key press
#14146
+46
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannager
added
the
component: data grid
|
@flaviendelangle would you like to give your input on this 😊 |
|
Hi, I'm not working on the data grid anymore |
romgrk
approved these changes
Sep 19, 2024
|
The code LGTM but I don't know how to test this or if we have existing automated tests. Have you tested this change? |
|
Deploy preview: https://deploy-preview-14146--material-ui-x.netlify.app/ |
|
Failing CI, that answers my question about automated tests. |
k-rajat19
force-pushed
the
IME-key-press
branch
from
55bf646
to
9fad4bf
Compare
|
@romgrk I've updated tests to reflect current behavior👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
event.whichis used for detecting IME composition event which is working fine but it is deprecated so we should find some other alternative for detecting IME key press. After some research, I found that we can useevent.typeproperty to check if the event is a composition event.there is also a
event.isComposingproperty which can be used but it is only supported in modern browsers.