-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data grid] Fix CSV export for null
and undefined
values
#14166
Conversation
not sure if this check should stay here or not, it probably not mui-x/packages/x-data-grid/src/hooks/features/export/serializers/csvSerializer.ts Lines 79 to 80 in 38184fe
|
null
and undefined
valuesnull
and undefined
values
I have removed this, thanks for pointing it out |
I have added a test to the PR, to prevent future regressions. |
Deploy preview: https://deploy-preview-14166--material-ui-x.netlify.app/ |
Fixes #14082
this issue comes from the changes done in #13560 , the motive of that PR is to convert any non-string value into a string using template literals but it also converts
null
andundefined
values into strings which then exported to CSV as a string.I have added a check for these values.