[core] Fix Netlify build cache issue

[cherniavskii]

Closes #14104

Netlify docs say the --shamefully-hoist flag is required for Next.js + pnpm setup, but as pointed out by @Janpot this guide doesn't apply to us since we build+export and just host a static site.

[mui-bot]

Deploy preview: https://deploy-preview-14182--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 1a4aa8f

[LukasTy]

LGTM. 👏
Thank you for all the effort on this matter! 🙏 💯

[MBilalShafi]

🎉

[michaldudak]

Just for the record - Core needs this as it uses Netlify functions.

[cherniavskii]

@michaldudak Hmm, I'm not sure using Netlify functions justifies the need for this flag, it seems to be required only when using Next.js/Nuxt + pnpm.

In certain scenarios, you must pass additional flags to the pnpm install command. For example, some frameworks such as Nuxt 3 and Next.js require that you modify the pnpm install command. To avoid import issues with pnpm and these frameworks, use the PNPM_FLAGS environment variable and set it to --shamefully-hoist.
https://docs.netlify.com/configure-builds/manage-dependencies/#pnpm

[LukasTy]

And to add salt to the injury—Core also had the same Netlify problems at the same time (not sure if it is still present on old PRs—probably is/would be). 🤔

[michaldudak]

@michaldudak Hmm, I'm not sure using Netlify functions justifies the need for this flag, it seems to be required only when using Next.js/Nuxt + pnpm.

When I was migrating the Core repo to pnpm, I had issues with functions that were unable to find transitive dependencies.

[LukasTy]

When I was migrating the Core repo to pnpm, I had issues with functions that were unable to find transitive dependencies.

But now there are no transitive dependencies needed by functions AFAIK.
Maybe it was before they were moved to the top level package.json? 🤔

[michaldudak]

If it works, I've got no objections to remove this flag :)