Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Add recipe for persisting filters in local storage #14208

Merged
merged 3 commits into from
Aug 15, 2024
Merged

[DataGrid] Add recipe for persisting filters in local storage #14208

merged 3 commits into from
Aug 15, 2024

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Aug 14, 2024 •
edited
Loading

@cherniavskii cherniavskii added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! feature: Filtering Related to the data grid Filtering feature customization: extend Logic customizability recipe labels Aug 14, 2024
@cherniavskii cherniavskii changed the title [docs] Add recipe for persisting filters in local storage [DataGrid] Add recipe for persisting filters in local storage Aug 14, 2024
@mui-bot
Copy link

mui-bot commented Aug 14, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-14208--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against d8fb572

@cherniavskii cherniavskii marked this pull request as ready for review August 14, 2024 14:20
@cherniavskii cherniavskii requested review from michelengelen and a team August 14, 2024 14:20
MBilalShafi
MBilalShafi approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice usage of React.useSyncExternalStore 👍

docs/data/data-grid/filtering-recipes/FilteringLocalStorage.tsx Outdated Show resolved Hide resolved
@cherniavskii cherniavskii enabled auto-merge (squash) August 15, 2024 11:25
@cherniavskii cherniavskii merged commit 3e2d3d0 into mui:master Aug 15, 2024
16 checks passed
@cherniavskii cherniavskii deleted the filtering-localStorage-recipe branch August 15, 2024 13:40
@shagg0r shagg0r mentioned this pull request Sep 14, 2024
Open
@alhabib5565 alhabib5565 mentioned this pull request Sep 14, 2024
Open
@mbreadmachine mbreadmachine mentioned this pull request Sep 14, 2024
Closed
@KOTTAGENVH KOTTAGENVH mentioned this pull request Sep 15, 2024
Open
@alhabib5565 alhabib5565 mentioned this pull request Sep 18, 2024
Open
@KOTTAGENVH KOTTAGENVH mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 19, 2024
Closed
Closed
This was referenced Sep 20, 2024
Open
Open
Open
Open
@alhabib5565 alhabib5565 mentioned this pull request Sep 24, 2024
Open
@mbreadmachine mbreadmachine mentioned this pull request Sep 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

@romgrk romgrk romgrk approved these changes

@michelengelen michelengelen Awaiting requested review from michelengelen

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! customization: extend Logic customizability docs Improvements or additions to the documentation feature: Filtering Related to the data grid Filtering feature recipe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Add a recipe for persisting filters on page refresh
4 participants
@cherniavskii @mui-bot @romgrk @MBilalShafi