-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TreeView] Do not re-render every Tree Item when the Rich Tree View re-renders (introduce selectors) #14210
Merged
flaviendelangle
merged 58 commits into
mui:master
from
flaviendelangle:selector-tree-view
Nov 15, 2024
Merged
[TreeView] Do not re-render every Tree Item when the Rich Tree View re-renders (introduce selectors) #14210
Changes from 45 commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
f0c8ac1
[TreeView] Introduce selectors
flaviendelangle a47c95e
Work
flaviendelangle e8a385c
Work
flaviendelangle 0518706
Fix
flaviendelangle 9ea8ab2
Fix tests
flaviendelangle 2abe440
Merge
flaviendelangle 9e302d2
Work for object children
flaviendelangle 2307a65
Work
flaviendelangle 479274f
Work
flaviendelangle eb00e1e
Work
flaviendelangle e9bbb6d
Work
flaviendelangle 4b6ae73
Work
flaviendelangle 99f3f07
Work
flaviendelangle a70d3dd
Work
flaviendelangle 87d1992
Fix doc examples
flaviendelangle 3cdc8f2
Work
flaviendelangle 1181d38
Fix
flaviendelangle 79228ef
Fix
flaviendelangle 4cef1db
Merge branch 'master' into selector-tree-view
flaviendelangle 66fde8c
Fix
flaviendelangle 4987b9a
Fix
flaviendelangle 451bac2
Fix
flaviendelangle 9302614
Merge branch 'master' into selector-tree-view
flaviendelangle 3b63a9d
Remove forceUpdate
flaviendelangle 01879e5
Fix
flaviendelangle f834dca
Work
flaviendelangle efae98d
Add tests
flaviendelangle ab57913
Work
flaviendelangle d9f5dc9
Work
flaviendelangle 7492a5e
Add JSDoc and improve DX
flaviendelangle da44f3a
Work
flaviendelangle 315c107
Regen api
flaviendelangle f3d1fda
Fix
flaviendelangle 59518ea
Fix
flaviendelangle 96e4287
Fix
flaviendelangle 909ed67
Merge branch 'master' into selector-tree-view
flaviendelangle 3412fea
Merge branch 'master' into selector-tree-view
flaviendelangle 41967f2
Add tests
flaviendelangle ad27780
Fix
flaviendelangle bf00041
Fix
flaviendelangle bb27ecb
Merge branch 'master' into selector-tree-view
flaviendelangle 86662f6
Fix
flaviendelangle 608757e
Fix
flaviendelangle 095c407
Merge
flaviendelangle c0871e3
Merge
flaviendelangle fb0c67d
Merge
flaviendelangle 2e8eec2
Merge branch 'master' into selector-tree-view
flaviendelangle 93a8d0f
Merge branch 'master' into selector-tree-view
flaviendelangle 43d7d3f
Review: Nora
flaviendelangle 21b820c
Merge branch 'master' into selector-tree-view
flaviendelangle aaa6c7d
Add migration guide
flaviendelangle 5172348
Merge branch 'master' into selector-tree-view
flaviendelangle d10fcc9
Merge branch 'master' into selector-tree-view
flaviendelangle 5933ee6
Merge branch 'master' into selector-tree-view
flaviendelangle 7fdd27d
Empty
flaviendelangle 4c37ec2
Merge branch 'master' into selector-tree-view
flaviendelangle 4d125f6
Merge branch 'master' into selector-tree-view
flaviendelangle fa353bd
Review: Nora
flaviendelangle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very dumb BC...
I need the id attribute in
TreeViewChildrenItemProvider
to be able to generate the defaultized id attribute on the 1st render?Why?
Because
state.items.itemMeta
is empty on the 1st render, before this PR it was not a problem because the item was rendering twice (because of lack of memoization) so we would get the item meta on the 2nd render.But now we only have one render and we can't access the
itemMeta
from the state.So we need another way to access the id attribute manually passed to
TreeItem
inSimpleTreeView
.I should have created
getContextProviderProps
from the beginning "just in case"