Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Add key prop to GridFilterInputMultipleValue #14302

Merged
merged 3 commits into from
Aug 29, 2024
Merged

[DataGrid] Add key prop to GridFilterInputMultipleValue #14302

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c750ba3
add key
sai6855 Aug 23, 2024
bc0c5ac
fix
sai6855 Aug 23, 2024
54252b9
Merge branch 'master' into add-key
sai6855 Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions packages/x-data-grid/src/components/panel/filterPanel/GridFilterInputMultipleValue.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,18 @@ function GridFilterInputMultipleValue(props: GridFilterInputMultipleValueProps)
value={filterValueState}
onChange={handleChange}
renderTags={(value, getTagProps) =>
value.map((option, index) => (
<rootProps.slots.baseChip
variant="outlined"
size="small"
label={option}
{...getTagProps({ index })}
/>
))
value.map((option, index) => {
const { key, ...tagProps } = getTagProps({ index });
return (
<rootProps.slots.baseChip
key={key}
variant="outlined"
size="small"
label={option}
{...tagProps}
/>
);
})
Comment on lines +68 to +79
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic is taken from

mui-x/packages/x-data-grid/src/components/panel/filterPanel/GridFilterInputMultipleSingleSelect.tsx

Lines 110 to 120 in 45b2835

renderTags={(value, getTagProps) =>
value.map((option, index) => {
const { key, ...tagProps } = getTagProps({ index });
return (
<rootProps.slots.baseChip
key={key}
variant="outlined"
size="small"
label={getOptionLabel(option)}
{...tagProps}
/>

}
renderInput={(params) => (
<rootProps.slots.baseTextField
Expand Down
Loading