Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump stylis to ^4.3.4 #14323

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Bump stylis to ^4.3.4 #14323

merged 1 commit into from
Sep 2, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 25, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
stylis ^4.3.2 -> ^4.3.4 age adoption passing confidence

Release Notes

thysultan/stylis.js (stylis)

v4.3.4

Compare Source

v4.3.3

Compare Source


Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Update of dependencies label Aug 25, 2024
@mui-bot
Copy link

mui-bot commented Aug 25, 2024

Deploy preview: https://deploy-preview-14323--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 0432c1e

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 26, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 26, 2024
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 28, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 29, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 29, 2024
@JCQuintas JCQuintas merged commit f7f58b3 into master Sep 2, 2024
18 checks passed
@JCQuintas JCQuintas deleted the renovate/stylis-4.x branch September 2, 2024 17:50
@LukasTy
Copy link
Member

LukasTy commented Sep 3, 2024

@JCQuintas on such core dependencies, especially ones that are coming from Core I tend to wait until they bump it first. 🙈
mui/material-ui#37791

@JCQuintas
Copy link
Member

🤔 I think I mistook this one for another. I was trying to figure out which ones come from core by seeing if they are duplicated in the package lock, which this one is, but it skipped me for some reason 😅

@JCQuintas
Copy link
Member

On another note, should we handle this differently? Like, I know we probably use this directly in our scripts, but we could define them as a required peerDep and set it to an exact version in the core/package.json, which probably would mean we always update to the correct one, and we wouldn't need to check 🤔

@LukasTy
Copy link
Member

LukasTy commented Sep 3, 2024

On another note, should we handle this differently? Like, I know we probably use this directly in our scripts, but we could define them as a required peerDep and set it to an exact version in the core/package.json, which probably would mean we always update to the correct one, and we wouldn't need to check 🤔

Once everything in common for docs to function is moved to @mui/docs we would get a more clear separation of what is a peer dependency and what is coming transitively from @mui/docs.
But this case is slightly different, because we use stylis explicitly in a few of our demos. 🙈
I think there is no problem here, but I would have still waited for other dependencies to catch up and Core to merge it first, given that this dependency is kind of integral part of the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants