Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Improve Dutch (nl-NL) locale #14398

Merged
merged 2 commits into from
Sep 3, 2024
Merged

[l10n] Improve Dutch (nl-NL) locale #14398

merged 2 commits into from
Sep 3, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Aug 30, 2024

Was reading through these docs and noticed the translations were incomplete, thought I'd quickly add those.

Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
@Janpot Janpot added the l10n localization label Aug 30, 2024
@mui-bot
Copy link

mui-bot commented Aug 30, 2024

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-14398--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against a33633d

@Janpot Janpot changed the title [i18n] Update nl_NL [i18n] Update Dutch (nl-NL) locale Aug 30, 2024
@Janpot Janpot marked this pull request as ready for review August 30, 2024 11:32
@oliviertassinari oliviertassinari changed the title [i18n] Update Dutch (nl-NL) locale [l10n] Update Dutch (nl-NL) locale Aug 31, 2024
columnsManagementSearchTitle: 'Zoeken',
columnsManagementNoColumns: 'Geen kolommen',
columnsManagementShowHideAllText: 'Toon/Verberg Alle',
columnsManagementReset: 'Reset',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
columnsManagementReset: 'Reset',
// columnsManagementReset: 'Reset',

Copy link
Member Author

@Janpot Janpot Aug 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intentional. You can use this in Dutch. Alternatives would likely be too long for this UI.
https://woordenlijst.org/zoeken/?q=reset

edit: 🤔 I just found the word "terugstellen", but I honestly have never seen that used in the wild.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it that we happy with the proposed translation. 🤔
In any case, this label would equal Reset in nl-NL locale and if someone will see it problematic, they can propose a better alternative. 👍

@LukasTy LukasTy added the component: data grid This is the name of the generic UI component, not the React module! label Sep 3, 2024
@LukasTy LukasTy changed the title [l10n] Update Dutch (nl-NL) locale [l10n] Improve Dutch (nl-NL) locale Sep 3, 2024
@LukasTy LukasTy merged commit 24943b0 into master Sep 3, 2024
20 checks passed
@LukasTy LukasTy deleted the Janpot-patch-1 branch September 3, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants