Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Update runners from node 18 to 20 #14466

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

JCQuintas
Copy link
Member

Some dependencies are starting to require node 20+, and as 18 starts entering maintenance mode, we will see this more and more.

@JCQuintas JCQuintas self-assigned this Sep 3, 2024
@JCQuintas JCQuintas added the scope: code-infra Specific to the core-infra product label Sep 3, 2024
@mui-bot
Copy link

mui-bot commented Sep 3, 2024

Deploy preview: https://deploy-preview-14466--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 13b9408

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍
WDYT about creating PRs on other repos to see if there are any issues there before merging? 🤔

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

@@ -56,7 +56,7 @@
{
"groupName": "@types/node",
"matchPackageNames": ["@types/node"],
"allowedVersions": "< 19.0.0"
"allowedVersions": "< 21.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot. 🙌 💯

@JCQuintas
Copy link
Member Author

PR on core passes as well mui/material-ui#43591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants