-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-infra] Update runners from node 18 to 20 #14466
Conversation
Deploy preview: https://deploy-preview-14466--material-ui-x.netlify.app/ |
This reverts commit 2fbaa97.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
WDYT about creating PRs on other repos to see if there are any issues there before merging? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go
@@ -56,7 +56,7 @@ | |||
{ | |||
"groupName": "@types/node", | |||
"matchPackageNames": ["@types/node"], | |||
"allowedVersions": "< 19.0.0" | |||
"allowedVersions": "< 21.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice spot. 🙌 💯
PR on core passes as well mui/material-ui#43591 |
Some dependencies are starting to require node 20+, and as 18 starts entering maintenance mode, we will see this more and more.