-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Move multi input range field validation tests to the describe test file #14501
Merged
flaviendelangle
merged 1 commit into
mui:master
from
flaviendelangle:validation-range-tests
Sep 5, 2024
Merged
[pickers] Move multi input range field validation tests to the describe test file #14501
flaviendelangle
merged 1 commit into
mui:master
from
flaviendelangle:validation-range-tests
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
test
core
Infrastructure work going on behind the scenes
component: pickers
This is the name of the generic UI component, not the React module!
labels
Sep 5, 2024
Deploy preview: https://deploy-preview-14501--material-ui-x.netlify.app/ |
flaviendelangle
requested review from
LukasTy,
michelengelen and
arthurbalduini
September 5, 2024 11:59
michelengelen
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LukasTy
changed the title
[core] Move multi input range field validation tests to the describe test file
[pickers] Move multi input range field validation tests to the describe test file
Sep 5, 2024
LukasTy
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for taking care of it. 👌
4 tasks
This was referenced Sep 27, 2024
arthurbalduini
pushed a commit
to arthurbalduini/mui-x
that referenced
this pull request
Sep 30, 2024
This was referenced Oct 3, 2024
This was referenced Oct 5, 2024
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: pickers
This is the name of the generic UI component, not the React module!
core
Infrastructure work going on behind the scenes
test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #14486
It was the only components to have this file structure.