[data grid] Improve GridToolbarExportProps type
#14524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-rajat19
commented
Sep 6, 2024
| @@ -32,7 +32,6 @@ export interface GridToolbarExportProps { | |||
| * @default {} | |||
| */ | |||
| slotProps?: { button?: Partial<ButtonProps>; tooltip?: Partial<TooltipProps> }; | |||
| [key: string]: any; | |||
There was a problem hiding this comment.
We should not be more explicit here, like excelOptions:any or some such; doing this will leak the type to community users as well which may not be good DX wise.
oliviertassinari
changed the title
GridToolbarExportProps typeGridToolbarExportProps type
zannager
added
the
component: data grid
|
this should be properly fixed in v8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14468