[license] Clean-up terminology to match codebase #14531
Conversation
oliviertassinari
added
core
oliviertassinari
force-pushed
the
license-remove-deprecated-API
branch
from
b70bc79
to
56f7276
Compare
|
Deploy preview: https://deploy-preview-14531--material-ui-x.netlify.app/ |
oliviertassinari
force-pushed
the
license-remove-deprecated-API
branch
from
56f7276
to
9bba507
Compare
oliviertassinari
force-pushed
the
license-remove-deprecated-API
branch
from
9bba507
to
0ead15a
Compare
| export const PLAN_VERSIONS = ['initial', 'Q3-2024'] as const; | ||
|
|
||
| export type LicenseScope = (typeof LICENSE_SCOPES)[number]; | ||
| export type PlanScope = (typeof PLAN_SCOPES)[number]; |
There was a problem hiding this comment.
This is public API strictly speaking
We can either keep exporting an LIcenseScope next to PlanScope, or don't care because nobody would actually use this variable
| */ | ||
| 'subscription', | ||
| ] as const; | ||
|
|
||
| export type LicensingModel = (typeof LICENSING_MODELS)[number]; | ||
| export type LicenseModel = (typeof LICENSE_MODELS)[number]; |
There was a problem hiding this comment.
This is public API strictly speaking
We can either keep exporting an LicensingModel next to LicenseModel, or don't care because nobody would actually use this variable
There was a problem hiding this comment.
We indeed use for this tool: https://tools-private.mui.com/prod/pages/x_licenseKey. But it's simple to handle on our side.
There was a problem hiding this comment.
But do we agree that it's a breaking change? Since it's exported from a package people install, and without an unstable or equivalent prefix.
There was a problem hiding this comment.
Technically, it's a breaking change, but we have never documented it and there is no practical use case for developers, so I think it's ok.
We have #9346 about the root problem.
|
Next step:
|
Those are the terminology that we use in the other parts of the codebase (the other repositories). Normally, this has no public API implications.