[DataGrid] Improve support of core v5 #1458
Conversation
oliviertassinari
added
bug 🐛
| @@ -148,14 +148,14 @@ function SettingsPanel(props) { | |||
|
|
|||
| return ( | |||
| <FormGroup className="MuiFormGroup-options" row> | |||
| <FormControl> | |||
| <FormControl variant="standard"> | |||
There was a problem hiding this comment.
it seems like it should be the default value.
There was a problem hiding this comment.
Standard was the default value, we changed it to outlined. I could gave gone the opposite direction, make the input field outlined but it seems to ues more space, so I didn't. If we want to use outlined, we would likely need to set the size to small.
There was a problem hiding this comment.
I think it is better as it is/was.
I meant that standard as a name for me should be the default.
Here, the default is outlined, and the standard is not the default
There was a problem hiding this comment.
Yes, standard is no longer the default in v5. As a matter of fact, standard is no longer inside the material design guidelines since 2018-2019.
|
For the curious ones, I found the issue in https://next.material-ui.com/components/tables/#data-table |
The issue: https://codesandbox.io/s/material-demo-forked-zg2fo
It's a follow-up on mui/material-ui#24895 by @petyosi
The fix works: https://codesandbox.io/s/material-demo-forked-kol9s?file=/package.json