Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release] v7.17.0 #14596

Merged
merged 11 commits into from
Sep 13, 2024
Merged

[release] v7.17.0 #14596

merged 11 commits into from
Sep 13, 2024

Conversation

arthurbalduini
Copy link
Member

No description provided.

@arthurbalduini arthurbalduini added the release We are shipping :D label Sep 12, 2024
@arthurbalduini arthurbalduini self-assigned this Sep 12, 2024
@mui-bot
Copy link

mui-bot commented Sep 12, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-14596--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 5487872

LukasTy
LukasTy reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least a few new public APIs were added to Pickers, I'm leaning towards a minor release, what do others think?

@flaviendelangle do you think it's too early to highlight #14514 and #14486?

CHANGELOG.md Outdated Show resolved Hide resolved
packages/x-charts-pro/package.json Outdated Show resolved Hide resolved
alexfauquette
alexfauquette reviewed Sep 12, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
arthurbalduini and others added 2 commits September 12, 2024 09:27
@arthurbalduini @LukasTy
Update packages/x-charts-pro/package.json
ecb9f87 
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com>
Signed-off-by: Arthur Suh Balduini <34691066+arthurbalduini@users.noreply.github.com>
@alexfauquette
Update CHANGELOG.md
95930e3 
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
cherniavskii
cherniavskii approved these changes Sep 12, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
arthurbalduini and others added 2 commits September 12, 2024 10:36
@arthurbalduini @cherniavskii @LukasTy
Apply suggestions from code review
6bf84cd 
Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com>
Signed-off-by: Arthur Suh Balduini <34691066+arthurbalduini@users.noreply.github.com>
@KenanYusuf
Update CHANGELOG.md
cb66e07 
Signed-off-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
KenanYusuf
KenanYusuf reviewed Sep 12, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
michelengelen
michelengelen reviewed Sep 12, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
LukasTy
LukasTy reviewed Sep 12, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@flaviendelangle
Copy link
Member

At least a few new public APIs were added to Pickers, I'm leaning towards a minor release, what do others think?

I'm fine having those new APIs in the changelog, maybe not highlighted because they are not documented yet (this will come with the read-only recipe I guess).
Fully agree that they justify a minor @LukasTy

flaviendelangle
flaviendelangle reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that small of a release this week 😃

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@arthurbalduini
Copy link
Member Author

At least a few new public APIs were added to Pickers, I'm leaning towards a minor release, what do others think?

I'm fine having those new APIs in the changelog, maybe not highlighted because they are not documented yet (this will come with the read-only recipe I guess). Fully agree that they justify a minor @LukasTy

Since there are other API changes on Charts in Tree View, would everyone agree on adding a generic highlight? Something like:
- ⛏️ API additions in Time Pickers, Charts and Tree View

@flaviendelangle @JCQuintas

@arthurbalduini @flaviendelangle @michelengelen
Apply suggestions from code review
6c06c3a 
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Co-authored-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
Signed-off-by: Arthur Suh Balduini <34691066+arthurbalduini@users.noreply.github.com>
@flaviendelangle
Copy link
Member

Since there are other API changes on Charts in Tree View, would everyone agree on adding a generic highlight? Something like:

  • ⛏️ API additions in Time Pickers, Charts and Tree View

Not sure that really needed
If the API is interesting enough to highlight, we highlight it, if not we don't
The more time flies, the less I am convinced by the "docs improvements" and "bug fixes", to me they feel like we try to justify that we did stuff.

@michelengelen @LukasTy
Update CHANGELOG.md
8f2da97 
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com>
Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
LukasTy
LukasTy reviewed Sep 13, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Arthur Balduini and others added 2 commits September 13, 2024 08:01
updates to minor version
1d20dc1
@arthurbalduini @LukasTy
Update CHANGELOG.md
5487872 
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com>
Signed-off-by: Arthur Suh Balduini <34691066+arthurbalduini@users.noreply.github.com>
@arthurbalduini arthurbalduini changed the title v7.16.1 v7.17.0 Sep 13, 2024
@arthurbalduini arthurbalduini merged commit 67b6e27 into mui:master Sep 13, 2024
15 of 16 checks passed
LukasTy
LukasTy reviewed Sep 13, 2024
View reviewed changes
packages/x-date-pickers-pro/package.json
@@ -1,6 +1,6 @@
{
"name": "@mui/x-date-pickers-pro",
"version": "7.16.0",
"version": "7.0.0-beta.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FLAG Hm... Are you sure?

@oliviertassinari oliviertassinari changed the title v7.17.0 [release] v7.17.0 Sep 22, 2024
arthurbalduini added a commit to arthurbalduini/mui-x that referenced this pull request Sep 30, 2024
@arthurbalduini
v7.17.0 (mui#14596)
4628865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

@KenanYusuf KenanYusuf KenanYusuf left review comments

@LukasTy LukasTy LukasTy left review comments

@flaviendelangle flaviendelangle flaviendelangle left review comments

@alexfauquette alexfauquette alexfauquette approved these changes

@michelengelen michelengelen michelengelen approved these changes

@MBilalShafi MBilalShafi MBilalShafi approved these changes

@JCQuintas JCQuintas JCQuintas approved these changes

@joserodolfofreitas joserodolfofreitas Awaiting requested review from joserodolfofreitas

@romgrk romgrk Awaiting requested review from romgrk

@arminmeh arminmeh Awaiting requested review from arminmeh

@DanailH DanailH Awaiting requested review from DanailH

Assignees

@arthurbalduini arthurbalduini

Labels
release We are shipping :D
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@arthurbalduini @mui-bot @flaviendelangle @LukasTy @KenanYusuf @JCQuintas @MBilalShafi @cherniavskii @michelengelen @alexfauquette