Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts][docs] Polish code formatting #14603

Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 12, 2024

Seems simpler to follow:

https://mui.com/x/react-charts/composition/#properties vs. https://deploy-preview-14603--material-ui-x.netlify.app/x/react-charts/composition/#properties

I struggled a bit to understand the code the first time I read it.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: charts This is the name of the generic UI component, not the React module! and removed docs Improvements or additions to the documentation labels Sep 12, 2024
@mui-bot
Copy link

mui-bot commented Sep 12, 2024

Deploy preview: https://deploy-preview-14603--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against aec0b95

Copy link

codspeed-hq bot commented Sep 12, 2024

CodSpeed Performance Report

Merging #14603 will improve performances by 10.97%

Comparing oliviertassinari:docs-chart-polish-composition (aec0b95) with master (7120da2)

Summary

⚡ 1 improvements
✅ 2 untouched benchmarks

Benchmarks breakdown

Benchmark master oliviertassinari:docs-chart-polish-composition Change
BarChart with big data amount 1.2 s 1.1 s +10.97%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants