Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fields] Remove clear button from the tab sequence #14616

Merged
merged 4 commits into from
Nov 6, 2024
Merged

[fields] Remove clear button from the tab sequence #14616

merged 4 commits into from
Nov 6, 2024
+1 −0

Conversation

k-rajat19
Copy link
Contributor

@k-rajat19 k-rajat19 commented Sep 14, 2024 •
edited
Loading

Fixes #14587
clear button should not be in the tab sequence. For more info see #14587
Preview : https://deploy-preview-14616--material-ui-x.netlify.app/x/react-date-pickers/date-picker/#clearing-the-value

@zannager zannager added the component: pickers This is the name of the generic UI component, not the React module! label Sep 16, 2024
@mui-bot
Copy link

mui-bot commented Sep 17, 2024

Deploy preview: https://deploy-preview-14616--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against e0d8aeb

@k-rajat19
Copy link
Contributor Author

k-rajat19 commented Sep 25, 2024 •
edited
Loading

hi @LukasTy @flaviendelangle
Are we good to go with this change :)

@flaviendelangle
Copy link
Member

I'd like @LukasTy opinion on this one, but no problem on my side 👍

@oliviertassinari oliviertassinari changed the title [pickers]: remove clear button in tab sequence [pickers] Remove clear button in tab sequence Oct 1, 2024
@k-rajat19
Copy link
Contributor Author

Hi @LukasTy,
Are there any blockers to merging this?

@LukasTy LukasTy added accessibility a11y enhancement This is not a bug, nor a new feature labels Nov 6, 2024
@LukasTy LukasTy changed the title [pickers] Remove clear button in tab sequence [pickers] Remove clear button from the tab sequence Nov 6, 2024
LukasTy
LukasTy approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of it. 🙏
Sorry for the delayed review. 🙈

The approach makes sense to me. 👌
We support the select all + Del/Backspace to remove the value, so, it shouldn't be a surprise to keyboard users.

@LukasTy LukasTy changed the title [pickers] Remove clear button from the tab sequence [fields] Remove clear button from the tab sequence Nov 6, 2024
@LukasTy LukasTy added the feature: Keyboard editing Related to the pickers keyboard edition label Nov 6, 2024
@LukasTy LukasTy merged commit 2483f78 into mui:master Nov 6, 2024
24 checks passed
@k-rajat19 k-rajat19 deleted the clear-button branch November 6, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

Assignees
No one assigned
Labels
accessibility a11y component: pickers This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature feature: Keyboard editing Related to the pickers keyboard edition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pickers] Remove clear button in tab sequence
5 participants
@k-rajat19 @mui-bot @flaviendelangle @LukasTy @zannager