[release] v7.18.0 #14670
Merged
[release] v7.18.0 #14670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenanYusuf
commented
Sep 19, 2024
|
Deploy preview: https://deploy-preview-14670--material-ui-x.netlify.app/ |
arminmeh
reviewed
Sep 19, 2024
flaviendelangle
approved these changes
Sep 19, 2024
cherniavskii
approved these changes
Sep 19, 2024
LukasTy
reviewed
Sep 19, 2024
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com> Co-authored-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com> Signed-off-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
KenanYusuf
commented
Sep 19, 2024
KenanYusuf
commented
Sep 19, 2024
|
@KenanYusuf The failing unit test is flaky, you can ignore it. I believe it will be fixed by #14583 |
MBilalShafi
approved these changes
Sep 20, 2024
LukasTy
approved these changes
Sep 20, 2024
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com> Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com> Signed-off-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
|
|
||
| - 💫 Support [Row spanning](https://mui.com/x/react-data-grid/row-spanning/) on the Data Grid that automatically merges the consecutive cells in a column based on the cell value | ||
|
|
||
| <img width="600" src="https://github.com/user-attachments/assets/d32ec936-d238-4c92-9e1a-af6788d74cdf" alt="data grid row spanning" /> |
There was a problem hiding this comment.
Adding a height would improve the UX.
Suggested change
| <img width="600" src="https://github.com/user-attachments/assets/d32ec936-d238-4c92-9e1a-af6788d74cdf" alt="data grid row spanning" /> | |
| <img width="600" height="326" src="https://github.com/user-attachments/assets/d32ec936-d238-4c92-9e1a-af6788d74cdf" alt="data grid row spanning" /> |
so the content doesn't move while reading the changelog after the video loads.
On the video itself, I think that correct scale + x2 pixel density + higher fps would improve the UX. See the guide in https://www.notion.so/mui-org/High-quality-media-5a1686758f4f4267989b67a1c2c270da?pvs=4#03d3a56e4f3e4890be21a6d56a005194. Here is how it feel for comparison:
There was a problem hiding this comment.
Cool, thanks for linking the page, it definitely looks better.
arthurbalduini
pushed a commit
to arthurbalduini/mui-x
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.