Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v6.20.5 #14672

Open
wants to merge 6 commits into
base: v6.x
Choose a base branch
from
Open

v6.20.5 #14672

wants to merge 6 commits into from
+29 −5

Conversation

KenanYusuf
Copy link
Contributor

No description provided.

@KenanYusuf KenanYusuf added the release We are shipping :D label Sep 19, 2024
@KenanYusuf KenanYusuf changed the title Release 6.20.5 v6.20.5 Sep 19, 2024
@mui-bot
Copy link

mui-bot commented Sep 19, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-14672--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 84fed8e

arminmeh
arminmeh reviewed Sep 19, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@arminmeh
Copy link
Contributor

Should other packages get a version bump as well?

@LukasTy
Copy link
Member

LukasTy commented Sep 19, 2024

Should other packages get a version bump as well?

We didn't have such an approach for releases on v6.
Besides, even on v7, we rely on Lerna, if it suggests a bump—we do it.

@KenanYusuf, could you try pushing an empty commit?
I have restarted the Netlify deployment without a cache and it succeeded: https://app.netlify.com/sites/material-ui-x/deploys/66ec0f80fad5db9154cd9c8f

@arminmeh
Update changelog
6aaa46f 
Signed-off-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com>
@arminmeh
Copy link
Contributor

@KenanYusuf, could you try pushing an empty commit?

I have applied my own suggestion 🙂

MBilalShafi
MBilalShafi approved these changes Sep 19, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
cherniavskii
cherniavskii reviewed Sep 19, 2024
View reviewed changes
packages/grid/x-data-grid-pro/package.json Outdated
Copy link
Member

@cherniavskii cherniavskii Sep 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did lerna bump the Pro and Community packages? Or is this bump only for version consistency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot we had a script 😅. Found it after reading the release guide again.

Lerna does not bump pro and community, so I'll undo that unless they should actually be bumped for consistency.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tend to release whatever lerna suggests, I wouldn't bump other packages in this case 👍🏻

KenanYusuf and others added 3 commits September 19, 2024 15:28
@KenanYusuf
undo version bump for data grid pro and community
e60968b
@KenanYusuf
fix inconsistency in changelog
b8f7cdb
@KenanYusuf @MBilalShafi
Update CHANGELOG.md
84fed8e 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Signed-off-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arminmeh arminmeh arminmeh approved these changes

@LukasTy LukasTy LukasTy approved these changes

@MBilalShafi MBilalShafi MBilalShafi approved these changes

@cherniavskii cherniavskii cherniavskii approved these changes

Assignees
No one assigned
Labels
release We are shipping :D
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KenanYusuf @mui-bot @arminmeh @LukasTy @MBilalShafi @cherniavskii