Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix checkboxSelectionVisibleOnly reset the selection on filtering #14677

Merged
merged 10 commits into from
Sep 28, 2024
Merged

[DataGrid] Fix checkboxSelectionVisibleOnly reset the selection on filtering #14677

merged 10 commits into from
Sep 28, 2024
+80 −8

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Sep 19, 2024 •
edited
Loading

@MBilalShafi MBilalShafi added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! regression A bug, but worse feature: Selection Related to the data grid Selection feature labels Sep 19, 2024
@mui-bot
Copy link

mui-bot commented Sep 19, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-14677--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against bfabc3d

@MBilalShafi MBilalShafi requested a review from a team September 24, 2024 10:37
@MBilalShafi @arminmeh
Update
bfabc3d 
Co-authored-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com>
Signed-off-by: Bilal Shafi <bilalshafidev@gmail.com>
@MBilalShafi MBilalShafi enabled auto-merge (squash) September 27, 2024 02:48
@MBilalShafi MBilalShafi merged commit 50f9889 into mui:master Sep 28, 2024
16 of 17 checks passed
@MBilalShafi MBilalShafi deleted the fix-checkboxSelectionVisibleOnly branch September 28, 2024 06:33
@MBilalShafi MBilalShafi mentioned this pull request Sep 28, 2024
Merged
11 tasks
This was referenced Oct 10, 2024
Closed
Closed
@arminmeh arminmeh mentioned this pull request Oct 31, 2024
Closed
1 task
This was referenced Nov 1, 2024
Open
Open
Open
@DMPatod DMPatod mentioned this pull request Nov 2, 2024
Open
@mbreadmachine mbreadmachine mentioned this pull request Nov 5, 2024
Merged
This was referenced Nov 8, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arminmeh arminmeh arminmeh approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature regression A bug, but worse
Projects
None yet
Milestone
No milestone
3 participants
@MBilalShafi @mui-bot @arminmeh