Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TreeView] Rework how items are being rendered in Rich Tree View components #14749

Merged

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Sep 27, 2024

Extracted from #14210 and #13520

In #13520, the idea is to pass the virtualized items to this component instead of all items.

@flaviendelangle flaviendelangle changed the title [TreeView] Rework how items are being rendering in Rich Tree View com… [TreeView] Rework how items are being rendering in Rich Tree View components Sep 27, 2024
@flaviendelangle flaviendelangle self-assigned this Sep 27, 2024
@flaviendelangle flaviendelangle added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label Sep 27, 2024
@mui-bot
Copy link

mui-bot commented Sep 27, 2024

Deploy preview: https://deploy-preview-14749--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 7f9e80d

Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, LGTM 🎉

@noraleonte noraleonte changed the title [TreeView] Rework how items are being rendering in Rich Tree View components [TreeView] Rework how items are being rendered in Rich Tree View components Oct 8, 2024
@flaviendelangle flaviendelangle merged commit 526ef4c into mui:master Oct 8, 2024
18 checks passed
@flaviendelangle flaviendelangle deleted the refacto-items-rendering branch October 8, 2024 10:09
@stephzero1
Copy link

this cause some performance improvements?

@flaviendelangle
Copy link
Member Author

No, it's a step toward unlocking #9685 and #14210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants