-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Copyedit pages.ts
navigation
#14782
[docs] Copyedit pages.ts
navigation
#14782
Conversation
Deploy preview: https://deploy-preview-14782--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you feel that slots and
part doesn't bring any clarity, I'm fine with it. 👌
But if we rename a menu item, shouldn't we also align that page heading as well? 🤔
I'd ask for a pair of eyes from @mui/xgrid given that most renaming impacts their links.
The main goal was to improve the searchability of this section. If we remove it from the sidebar, then I think it should at least be kept on the page title so that Algolia is able to find this page when searching for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This makes sense to me. The navbar change is more about aesthetics than anything else, but as long as the page is still discoverable via search then we should be good. |
I agree that grouping pages like we are doing on the pickers can be a nice middle ground between a collapsed folder and a totally flat structure. Just be careful, last time I tried, when you have a group and then a page below, the page below looks like its in the group, we should probably improve the padding to show that its outside of it. |
related to: #2904 (comment)