[charts] Type improvements & warnOnce usage
#14792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCQuintas
added
docs
|
Deploy preview: https://deploy-preview-14792--material-ui-x.netlify.app/ |
Comment on lines
62
to
63
| if (process.env.NODE_ENV !== 'production' && value !== null) { | ||
| warnOnce([ |
There was a problem hiding this comment.
Codebase convention. The idea was to make those ease to spot.
Suggested change
| if (process.env.NODE_ENV !== 'production' && value !== null) { | |
| warnOnce([ | |
| if (process.env.NODE_ENV !== 'production') { | |
| if (value !== null) { | |
| warnOnce([ |
If we implement mui/mui-public#207, we might not need this convention as much, not sure.
There was a problem hiding this comment.
Yeah I thought about dividing the checks too, but IIRC bundlers should remove it regardless of a second condition. Will divide it up 😅
CodSpeed Performance ReportMerging #14792 will not alter performanceComparing Summary
|
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com> Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
This was referenced Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some improvements and consistency I've found when working on another PR