-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] Adds community contribution section to the changelog script #14799
[infra] Adds community contribution section to the changelog script #14799
Conversation
Deploy preview: https://deploy-preview-14799--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement! 👍
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com> Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
@alelthomas quick review of the wording please? |
}; | ||
|
||
const logTeamSection = () => { | ||
return `Following are all team members who have contributed to this release:\n${Array.from( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure we need this? 🤔
By the way, WDYT about moving this to the top and replacing this existing somewhat pointless sentence:
We'd like to offer a big thanks to the ${authors.length} contributors who made this release possible. Here are some highlights ✨
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure we need this? 🤔
I am trying to align this with the approach the core team is taking and since they are currently listing all contributors (but will apply this change to their repo as well) they want to keep all mentions. Right @mnajdova?
By the way, WDYT about moving this to the top and replacing this existing somewhat pointless sentence:
I thought about this as well. Might be worth a shot. We can always move it back if we think this looks odd or misplaced. 👍🏼
Perfect! |
This will add a section below the highlights giving the community contributors a special shoutout. We can still work on providing a social shoutout as well, but this is a first step towards recognition of community contributions. 💪🏼
Running the changelog script will now add a section below the highlights that looks like this: