Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Adds community contribution section to the changelog script #14799

Merged

Conversation

michelengelen
Copy link
Member

@michelengelen michelengelen commented Oct 2, 2024

This will add a section below the highlights giving the community contributors a special shoutout. We can still work on providing a social shoutout as well, but this is a first step towards recognition of community contributions. 💪🏼

Running the changelog script will now add a section below the highlights that looks like this:

Special thanks go out to our community contributors who have helped make this release possible:
@AWAIS97, @chucamphong, @GMchris, @JakubSveda, @k-rajat19, @k725, @lawvs, @lhilgert9, @Miodini, @ntamas, @ruiaraujo012, @Sanderand, @thomasmoon, @vallereaugabriel.
Following are all team members who have contributed to this release:
@alexfauquette, @arminmeh, @arthurbalduini, @cherniavskii, @flaviendelangle, @Janpot, @JCQuintas, @KenanYusuf, @LukasTy, @MBilalShafi, @michelengelen, @noraleonte, @oliviertassinari, @romgrk, @sai6855, @samuelsycamore.

@michelengelen michelengelen added enhancement This is not a bug, nor a new feature scope: infra Org infrastructure work going on behind the scenes labels Oct 2, 2024
@michelengelen michelengelen self-assigned this Oct 2, 2024
@mui-bot
Copy link

mui-bot commented Oct 2, 2024

Deploy preview: https://deploy-preview-14799--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 6cfd1e9

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! 👍

scripts/releaseChangelog.mjs Outdated Show resolved Hide resolved
michelengelen and others added 2 commits October 2, 2024 10:29
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com>
Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
@michelengelen
Copy link
Member Author

@alelthomas quick review of the wording please?

};

const logTeamSection = () => {
return `Following are all team members who have contributed to this release:\n${Array.from(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we need this? 🤔

By the way, WDYT about moving this to the top and replacing this existing somewhat pointless sentence:

We'd like to offer a big thanks to the ${authors.length} contributors who made this release possible. Here are some highlights ✨

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we need this? 🤔

I am trying to align this with the approach the core team is taking and since they are currently listing all contributors (but will apply this change to their repo as well) they want to keep all mentions. Right @mnajdova?

By the way, WDYT about moving this to the top and replacing this existing somewhat pointless sentence:

I thought about this as well. Might be worth a shot. We can always move it back if we think this looks odd or misplaced. 👍🏼

@alelthomas
Copy link
Contributor

Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature scope: infra Org infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants