Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid][docs] Change demo name example #14822

Merged
merged 1 commit into from
Oct 7, 2024
Merged

[data grid][docs] Change demo name example #14822

merged 1 commit into from
Oct 7, 2024

Conversation

alelthomas
Copy link
Contributor

@alelthomas alelthomas commented Oct 4, 2024 •
edited by oliviertassinari
Loading

@alelthomas alelthomas added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! feature: Row spanning Related to the data grid Row spanning feature labels Oct 4, 2024
@mui-bot
Copy link

mui-bot commented Oct 4, 2024

Deploy preview: https://deploy-preview-14822--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 4bfccb2

@oliviertassinari oliviertassinari changed the title [DataGrid][docs] change demo name example [data grid][docs] Change demo name example Oct 6, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 6, 2024 •
edited
Loading

I guess the motivation for this change is that "George Floyd" has political implications, while Andrew Clark, https://x.com/acdlite, is a more neutral name / related to React?

@alelthomas
Copy link
Contributor Author

@oliviertassinari yup 👍

@alelthomas alelthomas merged commit 24d8bfe into mui:master Oct 7, 2024
23 of 24 checks passed
@DMPatod DMPatod mentioned this pull request Nov 2, 2024
Open
@mbreadmachine mbreadmachine mentioned this pull request Nov 5, 2024
Merged
This was referenced Nov 8, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romgrk romgrk romgrk approved these changes

@joserodolfofreitas joserodolfofreitas Awaiting requested review from joserodolfofreitas

@samuelsycamore samuelsycamore Awaiting requested review from samuelsycamore

@oliviertassinari oliviertassinari Awaiting requested review from oliviertassinari

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation feature: Row spanning Related to the data grid Row spanning feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alelthomas @mui-bot @oliviertassinari @romgrk