Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix onRowSelectionModelChange firing unnecessarily on initial render #14909

Merged
merged 4 commits into from
Oct 11, 2024
Merged

[DataGrid] Fix onRowSelectionModelChange firing unnecessarily on initial render #14909

merged 4 commits into from
Oct 11, 2024

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Oct 10, 2024 •
edited
Loading

@MBilalShafi MBilalShafi added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature labels Oct 10, 2024
@MBilalShafi MBilalShafi mentioned this pull request Oct 10, 2024
Closed
@mui-bot
Copy link

mui-bot commented Oct 10, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-14909--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 532a1bf

@MBilalShafi MBilalShafi marked this pull request as ready for review October 10, 2024 12:56
@MBilalShafi MBilalShafi requested a review from a team October 10, 2024 12:56
@MBilalShafi MBilalShafi merged commit ef0d5c7 into mui:master Oct 11, 2024
18 checks passed
@MBilalShafi MBilalShafi deleted the fix/row-selection-issue branch October 11, 2024 13:27
@KenanYusuf KenanYusuf mentioned this pull request Oct 24, 2024
Closed
1 task
This was referenced Nov 8, 2024
Open
Open
Open
@MBilalShafi MBilalShafi mentioned this pull request Nov 12, 2024
Closed
@arminmeh arminmeh mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

@KenanYusuf KenanYusuf KenanYusuf approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Updates handled with onRowSelectionModelChange while using treeData results in an error
4 participants
@MBilalShafi @mui-bot @KenanYusuf @cherniavskii