Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Clean the new ownerState object #15056

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Oct 22, 2024

Part of #14475

Based on Monday's meeting

Goals

  • Do not have frequent re-renders of all the components because of a ownerState update
  • Avoid confusion in some slots like day or monthButton (is disabled the state of the picker or the state of the button? now it's clear)

Strictly speaking, this PR is breaking for openPickerIcon, but we will break most other slots anyway so I can wait before writing a good migration guide 😆

@flaviendelangle flaviendelangle added the component: pickers This is the name of the generic UI component, not the React module! label Oct 22, 2024
@flaviendelangle flaviendelangle self-assigned this Oct 22, 2024
@mui-bot
Copy link

mui-bot commented Oct 22, 2024

Deploy preview: https://deploy-preview-15056--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against ce06381

@flaviendelangle flaviendelangle marked this pull request as ready for review October 22, 2024 11:49
Copy link
Member

@arthurbalduini arthurbalduini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 🎉
The prefix on the properties are indeed much more clear ! Thanks for taking care of it 💯

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. 👍
Bıeing explicit never hurts. 💯

@flaviendelangle flaviendelangle merged commit 4ca6caf into mui:master Oct 28, 2024
18 checks passed
@flaviendelangle flaviendelangle deleted the ownerState-clean branch October 28, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants